[
https://issues.apache.org/jira/browse/FLINK-23030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17366665#comment-17366665
]
Piotr Nowojski edited comment on FLINK-23030 at 6/21/21, 3:14 PM:
------------------------------------------------------------------
Thanks for reporting and fixing the bug!
Merged to master f46cfecf027
Merged to release-1.13 d0d40718c1e
Merged to release-1.12 38bf63b2fbe
was (Author: pnowojski):
Merged to master f46cfecf027
Merged to release-1.13 d0d40718c1e
Merged to release-1.12 38bf63b2fbe
> PartitionRequestClientFactory#createPartitionRequestClient should throw when
> network failure
> --------------------------------------------------------------------------------------------
>
> Key: FLINK-23030
> URL: https://issues.apache.org/jira/browse/FLINK-23030
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Network
> Affects Versions: 1.14.0, 1.13.1, 1.12.4
> Reporter: Jin Xing
> Assignee: Jin Xing
> Priority: Major
> Labels: pull-request-available, stale-blocker
> Fix For: 1.14.0, 1.12.5, 1.13.2
>
>
> In current _PartitionRequestClientFactory#createPartitionRequestClient_,
> _ChannelFuture#await()_ is invoked, thus to build a connection to remote
> synchronously.
> But with the doc of _io.netty.util.concurrent.Future_ [1] and its
> implementation _io.netty.channel.DefaultChannelPromise_ [2],
> _ChannelFuture#await()_ never throws when completed with failure. I guess
> what Flink needs is _ChannelFuture#sync()._
> [1] [https://netty.io/4.1/api/io/netty/util/concurrent/class-use/Future.html]
> [2]
> [https://github.com/netty/netty/blob/4.1/transport/src/main/java/io/netty/channel/DefaultChannelPromise.java]
>
> https://github.com/netty/netty/blob/4.1/common/src/main/java/io/netty/util/concurrent/DefaultPromise.java
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
