sjwiesman opened a new pull request #16228:
URL: https://github.com/apache/flink/pull/16228


   ## What is the purpose of the change
   
   FLINK-21947 Added support for TIMESTAMP_LTZ in the CSV format by replacing 
java.sql.Timestamp.valueOf with java.time.LocalDateTime.parse. 
Timestamp.valueOf internally calls `trim()` on the string before parsing while 
LocalDateTime.parse does not. This caused a breaking change where the CSV 
format can no longer parse timestamps of CSV's with spaces after the delimiter. 
We should manually re-add the call to trim to revert the behavior.
   
   
   ## Brief change log
   
   Add trim() to convertToTimestamp
   
   
   ## Verifying this change
   
   - Unit Test
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / 
don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to