tillrohrmann commented on a change in pull request #16231:
URL: https://github.com/apache/flink/pull/16231#discussion_r655960361
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointTestBase.java
##########
@@ -773,7 +774,9 @@ public Configuration getConfiguration(File checkpointDir) {
conf.set(
NettyShuffleEnvironmentOptions.NETWORK_BUFFERS_PER_CHANNEL, BUFFER_PER_CHANNEL);
conf.set(NettyShuffleEnvironmentOptions.NETWORK_REQUEST_BACKOFF_MAX, 60000);
- conf.setString(AkkaOptions.ASK_TIMEOUT, "1 min");
Review comment:
The `ASK_TIMEOUT` is already at 1 minute. How long did it take for the
test to fail? Are we really sure that it is the `ASK_TIMEOUT` which causes the
test instability? Is there some other timeout which might cause it?
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/UnalignedCheckpointTestBase.java
##########
@@ -773,7 +774,9 @@ public Configuration getConfiguration(File checkpointDir) {
conf.set(
NettyShuffleEnvironmentOptions.NETWORK_BUFFERS_PER_CHANNEL, BUFFER_PER_CHANNEL);
conf.set(NettyShuffleEnvironmentOptions.NETWORK_REQUEST_BACKOFF_MAX, 60000);
- conf.setString(AkkaOptions.ASK_TIMEOUT, "1 min");
+ conf.setString(AkkaOptions.ASK_TIMEOUT, "2 min");
+ conf.setLong(HeartbeatManagerOptions.HEARTBEAT_TIMEOUT, 100000L);
Review comment:
Why did you increase the heartbeat timeout? Did we see heartbeat losses?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
