dawidwys commented on a change in pull request #16221:
URL: https://github.com/apache/flink/pull/16221#discussion_r656023192
##########
File path:
flink-core/src/main/java/org/apache/flink/api/common/eventtime/CombinedWatermarkStatus.java
##########
@@ -66,25 +66,25 @@ public void add(PartialWatermark element) {
public boolean updateCombinedWatermark() {
long minimumOverAllOutputs = Long.MAX_VALUE;
- boolean hasOutputs = false;
+ // if we don't have any outputs minimumOverAllOutputs is not valid,
it's still
+ // at its initial Long.MAX_VALUE state and we must not emit that
+ if (partialWatermarks.isEmpty()) {
+ this.idle = true;
Review comment:
good idea!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
