[
https://issues.apache.org/jira/browse/FLINK-23078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17367185#comment-17367185
]
Zhilong Hong commented on FLINK-23078:
--------------------------------------
Thank you for reminding me, [~pnowojski]. I noticed that [~chesnay] has removed
{{TestingUtil.defaultExecutor().shutdownNow()}} from the teardown of
SchedulerBenchmarkBase. In fact, {{TestingUtil.defaultExecutor()}} is
introduced in {{DefaultSchedulerBuilder}}, which is widely used in tests
related to Scheduler. If {{TestingUtil.defaultExecutor()}} is not shutdown, JMH
may need to wait until the timeout. This will slow down the execution of the
scheduler benchmark. I think maybe it's better to preserve this teardown
function.
> Scheduler Benchmarks not compiling
> ----------------------------------
>
> Key: FLINK-23078
> URL: https://issues.apache.org/jira/browse/FLINK-23078
> Project: Flink
> Issue Type: Bug
> Components: Benchmarks, Runtime / Coordination
> Affects Versions: 1.14.0
> Reporter: Piotr Nowojski
> Assignee: Chesnay Schepler
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> {code:java}
> 07:46:50 [ERROR]
> /home/jenkins/workspace/flink-master-benchmarks/flink-benchmarks/src/main/java/org/apache/flink/scheduler/benchmark/SchedulerBenchmarkBase.java:21:44:
> error: cannot find symbol
> {code}
> CC [~chesnay] [~Thesharing]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
