XComp commented on a change in pull request #15898:
URL: https://github.com/apache/flink/pull/15898#discussion_r656118432
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/exceptionhistory/FailureHandlingResultSnapshot.java
##########
@@ -59,27 +59,49 @@
public static FailureHandlingResultSnapshot create(
FailureHandlingResult failureHandlingResult,
Function<ExecutionVertexID, Execution> latestExecutionLookup) {
+ return create(
+ failureHandlingResult.getExecutionVertexIdOfFailedTask(),
+ failureHandlingResult.getError(),
+ failureHandlingResult.getVerticesToRestart(),
+ failureHandlingResult.getTimestamp(),
+ latestExecutionLookup);
+ }
+
+ /**
+ * Creates a {@code FailureHandlingResultSnapshot} based on the passed
{@link
+ * FailureHandlingResult} and {@link ExecutionVertex ExecutionVertices}.
Review comment:
I was referring to that bit:
```suggestion
* Creates a {@code FailureHandlingResultSnapshot} based on the passed
{@link
* FailureHandlingResult} and {@link ExecutionVertex ExecutionVertices}.
```
The description does not match the method's signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
