akalash commented on a change in pull request #16135:
URL: https://github.com/apache/flink/pull/16135#discussion_r656345974
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointOptions.java
##########
@@ -47,7 +48,8 @@
FORCED_ALIGNED
}
- public static final long NO_ALIGNMENT_TIME_OUT = Long.MAX_VALUE;
+ /** The maximum possible value is Long.MAX_VALUE 'ns' but API receives
'ms'. */
+ public static final long NO_ALIGNMENT_TIME_OUT =
Duration.ofNanos(Long.MAX_VALUE).toMillis();
Review comment:
It was impossible to set NO_ALIGNMENT_TIME_OUT when alternating is
enabled because when we are registering the register timer it converts this
value to nanosecond which leads to the error because it was Long.MAX_VALUE.
We didn't see this problem because such a combination alternating +
NO_ALIGNEMNT_TIME_OUT didn't meet before my changes but after I moved
registerAlignmentTimer to checkNewCheckpoint some tests meet this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
