SteNicholas commented on a change in pull request #16142:
URL: https://github.com/apache/flink/pull/16142#discussion_r656831241
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/DynamicKafkaSerializationSchema.java
##########
@@ -166,6 +167,15 @@ public void setPartitions(int[] partitions) {
@Override
public String getTargetTopic(RowData element) {
+ // no explicit topic defined in table options, use the writable
metadata column topic
+ topic =
+ StringUtils.isNullOrWhitespaceOnly(topic)
Review comment:
@Airblader , the `KafkaOptions#validateSinkTopic` could ensure that
whitespace-only is mapped to null. And the `KafkaOptions#TOPIC` couldn't be
whitespace-only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
