XComp commented on a change in pull request #16249:
URL: https://github.com/apache/flink/pull/16249#discussion_r656933801
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterDescriptor.java
##########
@@ -24,8 +24,7 @@
import org.apache.flink.util.FlinkException;
/**
- * A descriptor to deploy a cluster (e.g. Yarn or Mesos) and return a Client
for Cluster
- * communication.
+ * A descriptor to deploy a cluster (e.g. Yarn ) and return a Client for
Cluster communication.
Review comment:
```suggestion
* A descriptor to deploy a cluster (e.g. Yarn) and return a Client for
Cluster communication.
```
nit: But maybe, we could even remove the brackets entirely. That should be
the job of the IDE and the JavaDoc generator to provide information about
subclasses
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
##########
@@ -523,90 +523,50 @@
// ------------------------ Mesos Configuration ------------------------
- /**
- * The initial number of Mesos tasks to allocate.
- *
- * @deprecated in favor of {@code MesosOptions#INITIAL_TASKS}.
- */
+ /** @deprecated has no effect */
Review comment:
I might get my answer later in the review but anyway (for documentation
purposes): Why don't we remove these parameters completely here?
##########
File path: docs/content.zh/docs/connectors/datastream/kafka.md
##########
@@ -457,7 +457,7 @@ Flink 的 Kafka 连接器通过 Flink 的 [metric 系统]({{< ref
"docs/ops/metr
Flink 通过 Kafka 连接器提供了一流的支持，可以对 Kerberos 配置的 Kafka 安装进行身份验证。只需在
`flink-conf.yaml` 中配置 Flink。像这样为 Kafka 启用 Kerberos 身份验证：
1. 通过设置以下内容配置 Kerberos 票据
- - `security.kerberos.login.use-ticket-cache`：默认情况下，这个值是 `true`，Flink 将尝试在
`kinit` 管理的票据缓存中使用 Kerberos 票据。注意！在 YARN 上部署的 Flink jobs 中使用 Kafka
连接器时，使用票据缓存的 Kerberos 授权将不起作用。使用 Mesos 进行部署时也是如此，因为 Mesos 部署不支持使用票据缓存进行授权。
Review comment:
I feel like we should let a Chinese speaker look over the Chinese
documentation just to be sure that we're not saying something strange at the
end? Or am I underestimating your Mandarin skills?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
