[
https://issues.apache.org/jira/browse/FLINK-3806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300691#comment-15300691
]
ASF GitHub Bot commented on FLINK-3806:
---------------------------------------
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/2036
[FLINK-3806] [gelly] Revert use of DataSet.count()
This leaves the Graph API unchanged but GatherSumApplyIteration and
ScatterGatherIteration now use broadcast variables to share the
numberOfVertices count. The PageRanks have been updated to use this feature.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink
3806_revert_use_of_dataset_count
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2036.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2036
----
commit c56cbf997ceaec7e54f5d0847e960337ca1d84ba
Author: Greg Hogan <[email protected]>
Date: 2016-05-25T15:06:01Z
[FLINK-3806] [gelly] Revert use of DataSet.count()
----
> Revert use of DataSet.count() in Gelly
> --------------------------------------
>
> Key: FLINK-3806
> URL: https://issues.apache.org/jira/browse/FLINK-3806
> Project: Flink
> Issue Type: Improvement
> Components: Gelly
> Affects Versions: 1.1.0
> Reporter: Greg Hogan
> Assignee: Greg Hogan
> Priority: Critical
> Fix For: 1.1.0
>
>
> FLINK-1632 replaced {{GraphUtils.count}} with {{DataSetUtils.count}}. The
> former returns a {{DataSet}} while the latter executes a job to return a Java
> value.
> {{DataSetUtils.count}} is called from {{Graph.numberOfVertices}} and
> {{Graph.numberOfEdges}} which are called from {{GatherSumApplyIteration}} and
> {{ScatterGatherIteration}} as well as the {{PageRank}} algorithms when the
> user does not pass the number of vertices as a parameter.
> As noted in FLINK-1632, this does make the code simpler but if my
> understanding is correct will materialize the Graph twice. The Graph will
> need to be reread from input, regenerated, or recomputed by preceding
> algorithms.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
