curcur commented on a change in pull request #15420: URL: https://github.com/apache/flink/pull/15420#discussion_r657663014
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/ChangelogStateBackendHandle.java ########## @@ -0,0 +1,154 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.state.changelog; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.runtime.state.KeyGroupRange; +import org.apache.flink.runtime.state.KeyedStateHandle; +import org.apache.flink.runtime.state.SharedStateRegistry; +import org.apache.flink.runtime.state.StateObject; +import org.apache.flink.util.ExceptionUtils; + +import org.apache.flink.shaded.guava18.com.google.common.io.Closer; + +import javax.annotation.Nullable; + +import java.io.Closeable; +import java.util.ArrayList; +import java.util.List; +import java.util.Objects; +import java.util.stream.Collectors; + +import static java.util.Collections.unmodifiableList; +import static org.apache.flink.util.Preconditions.checkArgument; + +/** + * A handle to ChangelogStateBackend state. Consists of the base and delta parts. Base part + * references materialized state (e.g. SST files), while delta part references state changes that + * were not not materialized at the time of the snapshot. Both are potentially empty lists as there + * can be no state or multiple states (e.g. after rescaling). + */ +@Internal +public interface ChangelogStateBackendHandle extends KeyedStateHandle { + List<KeyedStateHandle> getMaterializedStateHandles(); + + List<StateChangelogHandle> getNonMaterializedStateHandles(); Review comment: the order of `List<StateChangelogHandle> getNonMaterializedStateHandles()` matters; but the order of `List<KeyedStateHandle> getMaterializedStateHandles()` does not, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
