SteNicholas commented on pull request #16142: URL: https://github.com/apache/flink/pull/16142#issuecomment-867668574
> Thanks @SteNicholas. I left a couple of comments. Sorry for being so picky but the Kafka connector is the most important connector in Flink, so we need to make this bullet proof. I would suggest to have slightly different semantics for sinks. The `topic` option could be the list of allowed values for the metadata column. If `topic` option is not defined any value is supported in the metadata column. What do you think? @twalthr , thanks for your detailed review and I have addressed your comments for the update. IMO, if `topic` table option isn't defined, the value of the `topic` writable metadata column could accept any value and if the value is null or empty, this could be corrected by user self. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
