dawidwys commented on pull request #15055: URL: https://github.com/apache/flink/pull/15055#issuecomment-867680149
Correct me if I am wrong @gaoyunhaii , but I think I misunderstood the changes around `CheckpointBarrierHandler`. Those changes are not affecting computation of alignment metrics, but they try to track barriers per channels. I tried taking a different approach. Do you mind taking a look: https://github.com/dawidwys/flink/commit/c1a4867cd090997bd504f8e201324214bdebece3 WDYT? There are two benefits I see if we do it that way: 1. We keep all the internal states consistent regarding the blocked channels and channels that we might need to prioritize. 2. We keep the logic of handling multiple/single concurrent checkpoints separate. The corner cases from one side do not affect the other imo. I agree it might be a bit more lengthy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
