zentol commented on a change in pull request #16265:
URL: https://github.com/apache/flink/pull/16265#discussion_r658215548
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryConfiguration.java
##########
@@ -70,13 +70,19 @@ public long getQueryServiceMessageSizeLimit() {
// Static factory methods
// ------------------------------------------------------------------------
+ @VisibleForTesting
+ public static MetricRegistryConfiguration fromConfiguration(Configuration
configuration) {
+ return fromConfiguration(configuration, 10485760);
+ }
Review comment:
Test shouldn't have to worry about the maximum frame size; its a rather
annoying implementation detail of the RPC system. I've refactored it into a
test utility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
