JingsongLi opened a new pull request #16284:
URL: https://github.com/apache/flink/pull/16284
## What is the purpose of the change
See UpdatableTopNFunctionTest.testSortKeyChangesWhenOutputRankNumber
```
expectedOutput.add(updateBeforeRecord("book", 3L, 16, 1L));
expectedOutput.add(updateAfterRecord("book", 2L, 11, 1L));
expectedOutput.add(updateBeforeRecord("book", 2L, 19, 2L));
expectedOutput.add(updateAfterRecord("book", 3L, 16, 2L));
It should collect the third record and then collect the second record.
```
This wrong order will lead to the wrong implementation of the downstream,
because the records expected by the downstream has unique key, but the disorder
here will lead to the data being deleted by mistake.
## Brief change log
- Fix `UpdatableTopNFunction`, retract old row before collect new row.
## Verifying this change
`UpdatableTopNFunctionTest.testSortKeyChangesWhenOutputRankNumber `
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / no) no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / no) no
- The serializers: (yes / no / don't know) no
- The runtime per-record code paths (performance sensitive): (yes / no /
don't know) no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't
know) no
- The S3 file system connector: (yes / no / don't know) no
## Documentation
- Does this pull request introduce a new feature? (yes / no) no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
