SteNicholas commented on a change in pull request #16286:
URL: https://github.com/apache/flink/pull/16286#discussion_r658518114
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/entrypoint/YarnApplicationClusterEntryPoint.java
##########
@@ -129,16 +129,12 @@ private static PackagedProgramRetriever
getPackagedProgramRetriever(
final Configuration configuration,
final String[] programArguments,
@Nullable final String jobClassName)
- throws IOException {
+ throws IOException, FlinkException {
final File userLibDir =
YarnEntrypointUtils.getUsrLibDir(configuration).orElse(null);
final File userApplicationJar = getUserApplicationJar(userLibDir,
configuration);
- final ClassPathPackagedProgramRetriever.Builder retrieverBuilder =
- ClassPathPackagedProgramRetriever.newBuilder(programArguments)
- .setUserLibDirectory(userLibDir)
- .setJarFile(userApplicationJar)
- .setJobClassName(jobClassName);
- return retrieverBuilder.build();
+ return PackagedProgramRetrieverImpl.create(
Review comment:
This doesn't pass the `Configuration`.
##########
File path:
flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneApplicationClusterEntryPoint.java
##########
@@ -111,13 +111,9 @@ private static PackagedProgram getPackagedProgram(
private static PackagedProgramRetriever getPackagedProgramRetriever(
final String[] programArguments, @Nullable final String
jobClassName)
- throws IOException {
+ throws IOException, FlinkException {
final File userLibDir =
ClusterEntrypointUtils.tryFindUserLibDirectory().orElse(null);
- final ClassPathPackagedProgramRetriever.Builder retrieverBuilder =
- ClassPathPackagedProgramRetriever.newBuilder(programArguments)
- .setUserLibDirectory(userLibDir)
- .setJobClassName(jobClassName);
- return retrieverBuilder.build();
+ return PackagedProgramRetrieverImpl.create(userLibDir, jobClassName,
programArguments);
Review comment:
This doesn't pass the `Configuration`.
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/entrypoint/KubernetesApplicationClusterEntrypoint.java
##########
@@ -105,22 +105,20 @@ private static PackagedProgramRetriever
getPackagedProgramRetriever(
final Configuration configuration,
final String[] programArguments,
@Nullable final String jobClassName)
- throws IOException {
+ throws IOException, FlinkException {
final File userLibDir =
ClusterEntrypointUtils.tryFindUserLibDirectory().orElse(null);
- final ClassPathPackagedProgramRetriever.Builder retrieverBuilder =
- ClassPathPackagedProgramRetriever.newBuilder(programArguments)
- .setUserLibDirectory(userLibDir)
- .setJobClassName(jobClassName);
// No need to do pipelineJars validation if it is a PyFlink job.
if (!(PackagedProgramUtils.isPython(jobClassName)
|| PackagedProgramUtils.isPython(programArguments))) {
final List<File> pipelineJars =
KubernetesUtils.checkJarFileForApplicationMode(configuration);
Preconditions.checkArgument(pipelineJars.size() == 1, "Should only
have one jar");
- retrieverBuilder.setJarFile(pipelineJars.get(0));
+ return PackagedProgramRetrieverImpl.create(
Review comment:
This doesn't pass the `Configuration`.
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/entrypoint/KubernetesApplicationClusterEntrypoint.java
##########
@@ -105,22 +105,20 @@ private static PackagedProgramRetriever
getPackagedProgramRetriever(
final Configuration configuration,
final String[] programArguments,
@Nullable final String jobClassName)
- throws IOException {
+ throws IOException, FlinkException {
final File userLibDir =
ClusterEntrypointUtils.tryFindUserLibDirectory().orElse(null);
- final ClassPathPackagedProgramRetriever.Builder retrieverBuilder =
- ClassPathPackagedProgramRetriever.newBuilder(programArguments)
- .setUserLibDirectory(userLibDir)
- .setJobClassName(jobClassName);
// No need to do pipelineJars validation if it is a PyFlink job.
if (!(PackagedProgramUtils.isPython(jobClassName)
|| PackagedProgramUtils.isPython(programArguments))) {
final List<File> pipelineJars =
KubernetesUtils.checkJarFileForApplicationMode(configuration);
Preconditions.checkArgument(pipelineJars.size() == 1, "Should only
have one jar");
- retrieverBuilder.setJarFile(pipelineJars.get(0));
+ return PackagedProgramRetrieverImpl.create(
+ userLibDir, pipelineJars.get(0), jobClassName,
programArguments);
}
- return retrieverBuilder.build();
+
+ return PackagedProgramRetrieverImpl.create(userLibDir, jobClassName,
programArguments);
Review comment:
This doesn't pass the `Configuration`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
