[ 
https://issues.apache.org/jira/browse/FLINK-23009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17369716#comment-17369716
 ] 

Danny Cranmer edited comment on FLINK-23009 at 6/25/21, 9:37 PM:
-----------------------------------------------------------------

Agree with [~iemre] that the issue is the same, however I also agree with 
[~xintongsong] that this change has broken the build. 

The error we are seeing is:
{code:java}
Caused by: java.lang.ClassNotFoundException: 
org.apache.flink.kinesis.shaded.com.google.common.util.concurrent.internal.InternalFutureFailureAccess
    at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:605)
    at java.base/java.lang.ClassLoader.loadClassHelper(ClassLoader.java:1185)
    at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:1100)
    at 
org.apache.flink.util.FlinkUserCodeClassLoader.loadClassWithoutExceptionHandling(FlinkUserCodeClassLoader.java:64)
    at 
org.apache.flink.util.ChildFirstClassLoader.loadClassWithoutExceptionHandling(ChildFirstClassLoader.java:65)
    at 
org.apache.flink.util.FlinkUserCodeClassLoader.loadClass(FlinkUserCodeClassLoader.java:48)
    at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:1083)
    ... 65 more
{code}
Seems as though the SQL connector is missing some dependencies that require 
shading. In particular:
 - {{com.google.guava:failureaccess:jar:1.0.1}}

I have create a new PR containing the fix, let's see if the tests pass
 - https://github.com/apache/flink/pull/16297

 

 


was (Author: dannycranmer):
Agree with [~iemre] that the issue is the same, however I also agree with 
[~xintongsong] that this change has broken the build. 

The error we are seeing is:

{code}
Caused by: java.lang.ClassNotFoundException: 
org.apache.flink.kinesis.shaded.com.google.common.util.concurrent.internal.InternalFutureFailureAccess
    at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:605)
    at java.base/java.lang.ClassLoader.loadClassHelper(ClassLoader.java:1185)
    at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:1100)
    at 
org.apache.flink.util.FlinkUserCodeClassLoader.loadClassWithoutExceptionHandling(FlinkUserCodeClassLoader.java:64)
    at 
org.apache.flink.util.ChildFirstClassLoader.loadClassWithoutExceptionHandling(ChildFirstClassLoader.java:65)
    at 
org.apache.flink.util.FlinkUserCodeClassLoader.loadClass(FlinkUserCodeClassLoader.java:48)
    at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:1083)
    ... 65 more
{code}

Seems as though the SQL connector is missing some dependencies that require 
shading. In particular:
- {{com.google.guava:failureaccess:jar:1.0.1}}

I have create a new PR containing the fix, let's see if the tests pass
- https://github.com/apache/flink  

 

 

> Bump up Guava in Kinesis Connector
> ----------------------------------
>
>                 Key: FLINK-23009
>                 URL: https://issues.apache.org/jira/browse/FLINK-23009
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / Kinesis
>            Reporter: Emre Kartoglu
>            Assignee: Emre Kartoglu
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.14.0, 1.12.5, 1.13.2
>
>
> *Background*
> We maintain a copy of the Flink connector in our AWS GitHub group: 
> [https://github.com/awslabs/amazon-kinesis-connector-flink]
> We've recently upgraded the Guava library in our AWS copy as the version we 
> were using was quite old and had incompatible interface differences with the 
> later and more commonly used Guava versions. As part of this ticket we'll be 
> applying the same changes in the Flink repo 
> [https://github.com/apache/flink/tree/master/flink-connectors/flink-connector-kinesis]
>  
> *Scope*
>  * Upgrade Guava library in pom.xml
>  * Switch to 3-arg version of Guava Futures.addCallback method call, as the 
> old 2-arg version is no longer supported
> *Result*
> All existing and new tests should pass
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to