[
https://issues.apache.org/jira/browse/FLINK-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15302075#comment-15302075
]
ASF GitHub Bot commented on FLINK-3868:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1983#issuecomment-221873359
Thanks, Greg, this looks good all in all!
A few thinks we should do before merging this, in my opinion:
- I think all classes should be annotated with `@Internal`, because they
should not be used directly by users.
- The `NullValueComparator` can be simplified to not really operate on
the values at all. All NullValues are always the same. They are all equal, hash
to a constant value, etc.
- We were trying to get rid of the `Record` type - it was part of a very
old legacy API. It is still in there because some people ended up using it, but
I would like to add as little dependency to it as possible. Hence I'd suggest
to drop the `RecordSerializer`.
> Specialized CopyableValue serializers and comparators
> -----------------------------------------------------
>
> Key: FLINK-3868
> URL: https://issues.apache.org/jira/browse/FLINK-3868
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.1.0
> Reporter: Greg Hogan
> Assignee: Greg Hogan
> Fix For: 1.1.0
>
>
> This need was discussed on the mailing list [1] and will be obviated by code
> generation for POJO serializers and comparators [2] (as I understand, i.e.,
> {{LongValue}} will now simply be treated as a POJO which happens to contain a
> {{long}} and a specialized serializer and comparator will be generated).
> In the meantime, and since {{ValueTypeInfo}} will need to be reworked to use
> the new generators, I think it is worthwhile to add specialized serializers
> and comparators for the {{CopyableValue}} types.
> This will also provide another point of comparison for the performance of the
> generated serializers and comparators.
> [1]
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/Tuple-performance-and-the-curious-JIT-compiler-td10666.html
> [2] https://issues.apache.org/jira/browse/FLINK-3599
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
