zentol commented on a change in pull request #16312:
URL: https://github.com/apache/flink/pull/16312#discussion_r660026011
##########
File path: flink-runtime/pom.xml
##########
@@ -132,111 +138,6 @@ under the License.
<!-- Version is set in root POM -->
</dependency>
- <dependency>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
- </dependency>
-
- <dependency>
- <groupId>com.typesafe.akka</groupId>
-
<artifactId>akka-actor_${scala.binary.version}</artifactId>
- <!-- exclusions for dependency conversion -->
- <exclusions>
- <exclusion>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <dependency>
- <groupId>com.typesafe.akka</groupId>
-
<artifactId>akka-remote_${scala.binary.version}</artifactId>
- <!-- exclusions for dependency conversion -->
- <exclusions>
- <exclusion>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <!-- Transitive dependency of akka-remote that we explicitly
define to pin
- its version (our Hadoop dependency has overridden the
netty version in the past) -->
- <dependency>
- <groupId>io.netty</groupId>
- <artifactId>netty</artifactId>
- <version>3.10.6.Final</version>
- </dependency>
-
- <!-- Transitive dependency of akka-remote that we explicitly
define to keep it
- visible after the shading (without relocation!) of
akka-remote -->
- <dependency>
- <groupId>com.typesafe.akka</groupId>
-
<artifactId>akka-stream_${scala.binary.version}</artifactId>
- <!-- exclusions for dependency conversion -->
- <exclusions>
- <exclusion>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
- </exclusion>
- <exclusion>
- <groupId>com.typesafe</groupId>
- <artifactId>config</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <!-- Transitive dependency of akka-remote that we explicitly
define to keep it
- visible after the shading (without relocation!) of
akka-remote -->
- <dependency>
- <groupId>com.typesafe.akka</groupId>
-
<artifactId>akka-protobuf_${scala.binary.version}</artifactId>
- <!-- exclusions for dependency conversion -->
- <exclusions>
- <exclusion>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <dependency>
- <groupId>com.typesafe.akka</groupId>
-
<artifactId>akka-slf4j_${scala.binary.version}</artifactId>
- <!-- exclusions for dependency conversion -->
- <exclusions>
- <exclusion>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <dependency>
- <groupId>org.clapper</groupId>
-
<artifactId>grizzled-slf4j_${scala.binary.version}</artifactId>
- <!-- exclusions for dependency conversion -->
- <exclusions>
- <exclusion>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <dependency>
- <groupId>com.github.scopt</groupId>
Review comment:
yes, it is unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
