XComp commented on a change in pull request #16286:
URL: https://github.com/apache/flink/pull/16286#discussion_r660042732
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/deployment/application/JarManifestParser.java
##########
@@ -118,7 +118,7 @@ static JarFileWithEntryClass
findOnlyEntryClass(Iterable<File> jarFiles) throws
* @return Optional holding value of first found attribute
* @throws IOException If there is an error accessing the JAR
*/
- private static Optional<String> findFirstManifestAttribute(File jarFile,
String... attributes)
+ public static Optional<String> findFirstManifestAttribute(File jarFile,
String... attributes)
Review comment:
I use it in `ClasspathProvider.extractEntryClassNameFromJar`. Making the
method `protected` would make it unavailable there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
