AHeise commented on a change in pull request #16271:
URL: https://github.com/apache/flink/pull/16271#discussion_r660447758
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/ChainingOutput.java
##########
@@ -129,13 +126,7 @@ public void emitLatencyMarker(LatencyMarker latencyMarker)
{
@Override
public void close() {
- try {
- if (closeable != null) {
- closeable.close();
- }
- } catch (Exception e) {
- throw new ExceptionInChainedOperatorException(e);
- }
Review comment:
I don't think, I need to test an empty method. I have added a comment
that only things that are owned should be closed with a reference to this
ticket to protect against regressions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
