zentol commented on a change in pull request #16312:
URL: https://github.com/apache/flink/pull/16312#discussion_r660026011
##########
File path: flink-runtime/pom.xml
##########
@@ -132,111 +138,6 @@ under the License.
<!-- Version is set in root POM -->
</dependency>
- <dependency>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
- </dependency>
-
- <dependency>
- <groupId>com.typesafe.akka</groupId>
-
<artifactId>akka-actor_${scala.binary.version}</artifactId>
- <!-- exclusions for dependency conversion -->
- <exclusions>
- <exclusion>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <dependency>
- <groupId>com.typesafe.akka</groupId>
-
<artifactId>akka-remote_${scala.binary.version}</artifactId>
- <!-- exclusions for dependency conversion -->
- <exclusions>
- <exclusion>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <!-- Transitive dependency of akka-remote that we explicitly
define to pin
- its version (our Hadoop dependency has overridden the
netty version in the past) -->
- <dependency>
- <groupId>io.netty</groupId>
- <artifactId>netty</artifactId>
- <version>3.10.6.Final</version>
- </dependency>
-
- <!-- Transitive dependency of akka-remote that we explicitly
define to keep it
- visible after the shading (without relocation!) of
akka-remote -->
- <dependency>
- <groupId>com.typesafe.akka</groupId>
-
<artifactId>akka-stream_${scala.binary.version}</artifactId>
- <!-- exclusions for dependency conversion -->
- <exclusions>
- <exclusion>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
- </exclusion>
- <exclusion>
- <groupId>com.typesafe</groupId>
- <artifactId>config</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <!-- Transitive dependency of akka-remote that we explicitly
define to keep it
- visible after the shading (without relocation!) of
akka-remote -->
- <dependency>
- <groupId>com.typesafe.akka</groupId>
-
<artifactId>akka-protobuf_${scala.binary.version}</artifactId>
- <!-- exclusions for dependency conversion -->
- <exclusions>
- <exclusion>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <dependency>
- <groupId>com.typesafe.akka</groupId>
-
<artifactId>akka-slf4j_${scala.binary.version}</artifactId>
- <!-- exclusions for dependency conversion -->
- <exclusions>
- <exclusion>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <dependency>
- <groupId>org.clapper</groupId>
-
<artifactId>grizzled-slf4j_${scala.binary.version}</artifactId>
- <!-- exclusions for dependency conversion -->
- <exclusions>
- <exclusion>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
- </exclusion>
- </exclusions>
- </dependency>
-
- <dependency>
- <groupId>com.github.scopt</groupId>
Review comment:
yes, it is unnecessary
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/recovery/ProcessFailureCancelingITCase.java
##########
@@ -127,7 +127,10 @@ public void testCancelingOnProcessFailure() throws
Throwable {
final ScheduledExecutorService ioExecutor =
TestingUtils.defaultExecutor();
final HighAvailabilityServices haServices =
HighAvailabilityServicesUtils.createHighAvailabilityServices(
- config, ioExecutor,
AddressResolution.NO_ADDRESS_RESOLUTION);
+ config,
+ ioExecutor,
+ AddressResolution.NO_ADDRESS_RESOLUTION,
+ RpcSystem.load());
Review comment:
It does not really matter either way; the RpcSystem is a stateless
factory of sorts.
##########
File path:
flink-rpc/flink-rpc-akka/src/main/resources/META-INF/services/org.apache.flink.runtime.rpc.RpcSystem
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+org.apache.flink.runtime.rpc.akka.AkkaRpcSystem
Review comment:
no, this is required because we load it with a `ServiceLoader`
##########
File path: flink-runtime/pom.xml
##########
@@ -382,110 +273,6 @@ under the License.
<suppressionsLocation
combine.self="override">/tools/maven/suppressions-runtime.xml</suppressionsLocation>
</configuration>
</plugin>
- <!-- Scala Compiler -->
- <plugin>
- <groupId>net.alchim31.maven</groupId>
- <artifactId>scala-maven-plugin</artifactId>
- <executions>
- <!-- Run scala compiler in the
process-resources phase, so that dependencies on
- scala classes can be resolved
later in the (Java) compile phase -->
- <execution>
- <id>scala-compile-first</id>
- <phase>process-resources</phase>
- <goals>
- <goal>compile</goal>
- </goals>
- </execution>
-
- <!-- Run scala compiler in the
process-test-resources phase, so that dependencies on
- scala classes can be resolved
later in the (Java) test-compile phase -->
- <execution>
- <id>scala-test-compile</id>
-
<phase>process-test-resources</phase>
- <goals>
- <goal>testCompile</goal>
- </goals>
- </execution>
- </executions>
- <configuration>
- <jvmArgs>
- <jvmArg>-Xms128m</jvmArg>
- <jvmArg>-Xmx512m</jvmArg>
- </jvmArgs>
- </configuration>
- </plugin>
-
- <!-- Eclipse Integration -->
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-eclipse-plugin</artifactId>
Review comment:
No, it should be added again.
##########
File path:
flink-rpc/flink-rpc-akka/src/main/resources/META-INF/services/org.apache.flink.runtime.rpc.RpcSystem
##########
@@ -0,0 +1,16 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+org.apache.flink.runtime.rpc.akka.AkkaRpcSystem
Review comment:
Essentially, this file acts as a lookup for available implementations of
an interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
