XComp commented on a change in pull request #16296: URL: https://github.com/apache/flink/pull/16296#discussion_r660332568
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/metrics/MetricRegistryTestUtils.java ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.metrics; + +import org.apache.flink.configuration.Configuration; + +/** Test utilities for the metric registries. */ +public class MetricRegistryTestUtils { + + private static volatile MetricRegistryConfiguration defaultConfiguration; Review comment: Out of curiosity: Why do we provide a `volatile` `static` member here that is a lazily instantiated singleton with an empty `Configuration`? Can't we do it once at startup time? Or am I missing something here. ########## File path: flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala ########## @@ -368,25 +369,6 @@ object AkkaUtils { ConfigFactory.parseString(configString) } - def testDispatcherConfig: Config = { - val config = - s""" - |akka { - | actor { - | default-dispatcher { - | fork-join-executor { - | parallelism-factor = 1.0 Review comment: Just for documentation purposes: I verified that the configuration which is removed here matches the configuration added to [RpcUtils:162](https://github.com/apache/flink/blob/b4b3787c4f62baecf8df4e12c695715e491aec4e/flink-rpc/flink-rpc-core/src/main/java/org/apache/flink/runtime/rpc/RpcUtils.java#L162) ########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryConfiguration.java ########## @@ -76,7 +73,8 @@ public long getQueryServiceMessageSizeLimit() { * @param configuration to generate the metric registry configuration from Review comment: Missing JavaDoc for `maximumFrameSize` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
