[ 
https://issues.apache.org/jira/browse/FLINK-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15303904#comment-15303904
 ] 

ASF GitHub Bot commented on FLINK-3129:
---------------------------------------

GitHub user rmetzger opened a pull request:

    https://github.com/apache/flink/pull/2042

    [FLINK-3129] Add tooling to ensure interface stability

    This pull request adds a maven module for ensuring interface stability 
(japicmp).
    
    I needed to revert some of the changes since 1.0:
    - I added the `public static final String CONFIG_KEY` in the 
`ExecutionConfig` again.
    - I made the `getMetricGroup()` in the `RuntimeContext` an evolving API.
    - I added two deprecated config constants again.
    - I reintroduced the deprecated `Key` interface.
    
    Once this has been merged, I'll file JIRAs for 2.0 to remove these changes.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rmetzger/flink flink3129-third

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2042.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2042
    
----
commit fd0e81558953f04b07dd5edaec58e9fe73903a7f
Author: Robert Metzger <rmetz...@apache.org>
Date:   2015-12-07T14:45:57Z

    [FLINK-3129] Bring infrastructure for ensuring interface stability in place

commit b15d5b84dd714fb6660b51ce72f03f1f25c134b8
Author: Robert Metzger <rmetz...@apache.org>
Date:   2016-05-27T08:53:35Z

    [FLINK-3129] Fix breaking changes in flink-core

commit b53b4805a70f2c0ae678bf41148c82e04b531417
Author: Robert Metzger <rmetz...@apache.org>
Date:   2016-05-27T10:09:45Z

    [FLINK-3129] Fix ES2 issue

----


> Add tooling to ensure interface stability
> -----------------------------------------
>
>                 Key: FLINK-3129
>                 URL: https://issues.apache.org/jira/browse/FLINK-3129
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Build System
>            Reporter: Robert Metzger
>            Assignee: Robert Metzger
>
> I would like to use this maven plugin: https://github.com/siom79/japicmp to 
> automatically ensure interface stability across minor releases.
> Ideally we have the plugin in place after Flink 1.0 is out, so that maven 
> builds break if a breaking change has been made.
> The plugin already supports downloading a reference release, checking the 
> build and breaking it.
> Not yet supported are class/method inclusions based on annotations, but I've 
> opened a pull request for adding it.
> There are also issues with the resolution of the dependency with the 
> annotations, but I'm working on resolving those issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to