wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r661993643
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BoundedBlockingSubpartitionDirectTransferReader.java
##########
@@ -110,7 +114,12 @@ private void updateStatistics(Buffer buffer) {
public boolean isAvailable(int numCreditsAvailable) {
// We simply assume there are no events except EndOfPartitionEvent for
bath jobs,
// then it has no essential effect to ignore the judgement of next
event buffer.
- return numCreditsAvailable > 0 && numDataAndEventBuffers > 0;
+ return (numCreditsAvailable > 0 || numDataBuffers == 0) &&
numDataAndEventBuffers > 0;
Review comment:
Yes, you are right. At the downstream task, no credit is needed when
decoding an event.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
