wsry commented on a change in pull request #11877:
URL: https://github.com/apache/flink/pull/11877#discussion_r662020759
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java
##########
@@ -100,8 +106,19 @@ public void addCredit(int creditDeltas) {
numCreditsAvailable += creditDeltas;
}
+ @Override
+ public boolean needAnnounceBacklog() {
+ return initialCredit == 0 && numCreditsAvailable == 0;
+ }
+
@Override
public void resumeConsumption() {
+ if (initialCredit == 0) {
+ // reset available credit if no exclusive buffer is available at
the
+ // consumer side for all floating buffers must have been released
+ numCreditsAvailable = 0;
Review comment:
Yes, you are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
