wsry commented on pull request #11877: URL: https://github.com/apache/flink/pull/11877#issuecomment-871983588
Hi @akalash really thanks for the review and comments. I must admit that this PR is pretty fragmented and is not easy to review. One reason is that the existing implementation relies heavily on the assumption that the exclusive credit is not 0. However, this PR breaks this assumption. Many changes in this PR is to achieve the goal of allocating floating credits at the downstream side according to backlog of the upstream task strictly if there is no exclusive credit. One buffer one credit, no more and no less (event does not take any credit). If this is not guaranteed, credit deadlock may occur. Thanks again for the review. I will run more tests to guarantees the correctness of this change. (Previously, I already ran some tests including the azure pipeline when setting the exclusive buffer to 0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
