gaoyunhaii commented on a change in pull request #15055:
URL: https://github.com/apache/flink/pull/15055#discussion_r662330728
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RecoveredInputChannel.java
##########
@@ -205,6 +205,12 @@ public void resumeConsumption() {
throw new UnsupportedOperationException("RecoveredInputChannel should
never be blocked.");
}
+ @Override
+ public void acknowledgeAllRecordsProcessed() throws IOException {
+ throw new UnsupportedOperationException(
+ "RecoveredInputChannel should not need acknowledge all records
processed.");
+ }
+
Review comment:
Hi, sorry I might not be fully familiar with this part, but I checked
the logic of converting the recovered input channels into real channels, and it
seems the converting happens before requesting partitions in
`SingleInputGate#requestPartitions`? If so, the `EndOfUserRecordsEvent` seems
to be only be actually received after converting into remote / local input
channels ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
