pnowojski commented on a change in pull request #15055:
URL: https://github.com/apache/flink/pull/15055#discussion_r662539753
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RecoveredInputChannel.java
##########
@@ -205,6 +205,12 @@ public void resumeConsumption() {
throw new UnsupportedOperationException("RecoveredInputChannel should
never be blocked.");
}
+ @Override
+ public void acknowledgeAllRecordsProcessed() throws IOException {
+ throw new UnsupportedOperationException(
+ "RecoveredInputChannel should not need acknowledge all records
processed.");
+ }
+
Review comment:
Yes you are right @gaoyunhaii. But what if upstream emits
`EndOfUserRecordsEvent` before unaligned checkpoint is triggered, and unaligned
checkpoint barrier happens when `EndOfUserRecordsEvent` is still in the input
buffers on the downstream task.
Do we have an ITCase for FLIP-147? If so what happens with unaligned
checkpoints?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
