zhuzhurk commented on a change in pull request #16173:
URL: https://github.com/apache/flink/pull/16173#discussion_r662769544



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/EdgeManagerBuildUtil.java
##########
@@ -58,6 +58,26 @@ static void connectVertexToResult(
         }
     }
 
+    /**
+     * Given parallelisms of two job vertices, calculate the max number of 
input or output edges of
+     * each execution in the first job vertex.
+     *
+     * @param thisParallelism parallelism of the first job vertex.
+     * @param targetParallelism parallelism of the second job vertex.
+     * @param distributionPattern the {@link DistributionPattern} of the 
connecting edge.
+     */
+    public static int getMaxNumEdgesToTarget(

Review comment:
       Maybe `computeMaxEdgesToTargetExecutionVertex(int targetParallelism, int 
sourceParallelism, DistributionPattern distributionPattern)`?
   And the java docs can be "Given parallelisms of two job vertices, compute 
the max number of edges connected to a target execution vertex from the source 
execution vertices. Note that edges is considered undirected here. It can be an 
edge connected from an upstream job vertex to a downstream job vertex, or in a 
reversed way."




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to