NicoK commented on a change in pull request #16352:
URL: https://github.com/apache/flink/pull/16352#discussion_r662819960
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java
##########
@@ -740,20 +740,19 @@ public WebMonitorEndpoint(
jobVertexBackPressureHandler.getMessageHeaders(),
jobVertexBackPressureHandler));
- if (clusterConfiguration.get(RestOptions.ENABLE_FLAMEGRAPH)) {
- final JobVertexFlameGraphHandler jobVertexFlameGraphHandler =
- new JobVertexFlameGraphHandler(
- leaderRetriever,
- timeout,
- responseHeaders,
- executionGraphCache,
- executor,
- initializeThreadInfoTracker(executor));
- handlers.add(
- Tuple2.of(
- jobVertexFlameGraphHandler.getMessageHeaders(),
- jobVertexFlameGraphHandler));
- }
+ final JobVertexFlameGraphHandler jobVertexFlameGraphHandler =
+ new JobVertexFlameGraphHandler(
+ leaderRetriever,
+ timeout,
+ responseHeaders,
+ executionGraphCache,
+ executor,
+ initializeThreadInfoTracker(executor),
Review comment:
Is it actually worth to also skip creating this if Flamegraphs are not
enabled? How much overhead is this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
