gaoyunhaii edited a comment on pull request #15055: URL: https://github.com/apache/flink/pull/15055#issuecomment-872845284
Hi @pnowojski @dawidwys , very thanks for the review! I have updated the PR to fix the commented issues~ And very thanks @dawidwys for looking into the test issue! I'm also checking this issue, and the found reason is the same: suspend default action only take effects after at least one mail get processed, currently a signal check mail is sent afterward to ensure the state is checked, but for the finish case this mail is consumed when closing operators. I also think it would be better to have a consistent semantics, but one possible concern is that might it affect the performance since it is in the hot code path~? Would it also be possible if we first also use the signal check mail here and we re-evaluate the mailbox changes in a separate issue~? I think we might also need some change change to the current implementation like we may not need the signal check mail if we do the change~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
