luoyuxia commented on a change in pull request #16149:
URL: https://github.com/apache/flink/pull/16149#discussion_r663676065
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogGenericMetadataTest.java
##########
@@ -317,6 +319,21 @@ public void testFunctionCompatibility() throws Exception {
assertEquals(FunctionLanguage.JAVA,
catalogFunction.getFunctionLanguage());
}
+ @Test
+ public void testGenericTableWithoutConnectorProp() throws Exception {
+ catalog.createDatabase(db1, createDb(), false);
+ TableSchema tableSchema =
+ TableSchema.builder()
+ .fields(
+ new String[] {"s", "ts"},
+ new DataType[] {DataTypes.STRING(),
DataTypes.TIMESTAMP_LTZ(3)})
+ .watermark("ts", "ts-INTERVAL '1' SECOND",
DataTypes.TIMESTAMP_LTZ(3))
+ .build();
+ CatalogTable catalogTable = new CatalogTableImpl(tableSchema,
Collections.emptyMap(), null);
+ catalog.createTable(path1, catalogTable, false);
+ assertEquals(tableSchema, catalog.getTable(path1).getSchema());
Review comment:
Should we assert the table's property IS_GENERIC is true in here as for
such table without 'connector' or 'connector.type', this pr will put IS_GENERIC
= true into it's properties .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
