zentol commented on a change in pull request #16286:
URL: https://github.com/apache/flink/pull/16286#discussion_r663781616
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/deployment/application/FromJarEntryClassInformationProvider.java
##########
@@ -68,11 +68,33 @@ private FromJarEntryClassInformationProvider(
this.jobClassName = jobClassName;
}
+ /**
+ * Returns the specified {@code jarFile}. If no {@code jarFile} was
specified it can only return
+ * an empty {@code Optional} if the {@code jobClassName} is specified
instead. In that case, the
Review comment:
The condition when it returns an empty optional is unnecessary and just
creates confusion. The jar _and_ classname not being specified is a case that a
consumer of this APIn ever has to be concerned with because the constructor
rejects it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
