zentol commented on a change in pull request #16332:
URL: https://github.com/apache/flink/pull/16332#discussion_r664312785
##########
File path: flink-test-utils-parent/flink-test-utils/pom.xml
##########
@@ -116,7 +116,7 @@ under the License.
</exclusions>
</dependency>
- </dependencies>
+ </dependencies>
Review comment:
this doesnt seem right
##########
File path:
flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/TestContainerVersions.java
##########
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.tests.util;
+
+import org.testcontainers.utility.DockerImageName;
+
+/**
+ * Utility class for defining the image names and versions of Docker
containers used during the
+ * end-to-end Java tests. The names/versions are centralised here in order to
make testing version
+ * updates easier, as well as to provide a central file to use as a key when
caching testing Docker
+ * files.
+ */
+public class TestContainerVersions {
+ public static final DockerImageName KAFKA =
Review comment:
Why is this using `DockerImageName` while the other class uses plain
`String`s?
##########
File path:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/TestContainerVersions.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.test.util;
+
+/**
+ * Utility class for defining the image names and versions of Docker
containers used during the Java
+ * tests. The names/versions are centralised here in order to make testing
version updates easier,
+ * as well as to provide a central file to use as a key when caching testing
Docker files.
+ */
+public class TestContainerVersions {
Review comment:
I'd think that this separation into ITCases/E2E tests will be broken
pretty quickly; not sure how much we'll really benefit from it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
