JingsongLi commented on pull request #16163: URL: https://github.com/apache/flink/pull/16163#issuecomment-874574343
Hi @zicat , it seems that we only have one problem: override copy. I still feel it is dangerous, not only resultType, but also nullTerm, resultTerm and etc... It may brings a wrong result. I have tested `SELECT func(func(func(text))) FROM MyTable`. There is no `copy` invoking. Why not just remove `copy`? Let `ExternalGeneratedExpression` fallback to `GeneratedExpression` when `copy` occurred. Or show your case that `copy` occurred. See can we optimize it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
