Airblader commented on a change in pull request #16287:
URL: https://github.com/apache/flink/pull/16287#discussion_r664395648
##########
File path:
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/api/TableEnvironmentTest.java
##########
@@ -78,6 +78,19 @@ public void testConnect() {
assertCatalogTable(CatalogTableImpl.fromProperties(table.toProperties()));
}
+ @Test
+ public void testTableFromDescriptor() {
+ final TableEnvironmentMock tEnv =
TableEnvironmentMock.getStreamingInstance();
+
+ final Schema schema = Schema.newBuilder().column("f0",
DataTypes.INT()).build();
+ final TableDescriptor descriptor =
+ TableDescriptor.forConnector("fake").schema(schema).build();
+
+ Table table = tEnv.from(descriptor);
+ assertEquals(
Review comment:
Do you mean `getQueryOperation`? That'll be a `CatalogQueryOperation`
which only has the identifier and resolved schema. I don't think there's a way
to the underlying table (other than looking it up ourselves), but even so we
have no table to compare it against; we'd need to assert individual parts
anyway, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
