zentol commented on a change in pull request #16345:
URL: https://github.com/apache/flink/pull/16345#discussion_r663743774
##########
File path: flink-rpc/flink-rpc-akka/pom.xml
##########
@@ -53,102 +59,89 @@ under the License.
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>org.scala-lang</groupId>
+ <artifactId>scala-reflect</artifactId>
+ <scope>compile</scope>
+ </dependency>
<dependency>
<groupId>org.scala-lang</groupId>
<artifactId>scala-library</artifactId>
+ <scope>compile</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.scala-lang</groupId>
+ <artifactId>scala-compiler</artifactId>
+ <scope>compile</scope>
</dependency>
<dependency>
<groupId>com.typesafe.akka</groupId>
-
<artifactId>akka-actor_${scala.binary.version}</artifactId>
- <!-- exclusions for dependency conversion -->
- <exclusions>
- <exclusion>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
- </exclusion>
- </exclusions>
+
<artifactId>akka-actor_${akka.scala.binary.version}</artifactId>
+ <version>${akka.version}</version>
</dependency>
-
<dependency>
<groupId>com.typesafe.akka</groupId>
-
<artifactId>akka-remote_${scala.binary.version}</artifactId>
- <!-- exclusions for dependency conversion -->
+
<artifactId>akka-remote_${akka.scala.binary.version}</artifactId>
+ <version>${akka.version}</version>
<exclusions>
<exclusion>
- <groupId>org.scala-lang</groupId>
- <artifactId>scala-library</artifactId>
+ <groupId>io.aeron</groupId>
+ <artifactId>aeron-driver</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>io.aeron</groupId>
+ <artifactId>aeron-client</artifactId>
</exclusion>
Review comment:
Ill add a comment
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
##########
@@ -250,7 +252,10 @@ public void close() throws Exception {
FutureUtils.composeAfterwards(
taskManagerTerminationFuture,
this::shutDownServices);
- serviceTerminationFuture.whenComplete(
+ final CompletableFuture<Void> rpcSystemClassLoaderCloseFuture =
+ FutureUtils.runAfterwards(serviceTerminationFuture,
rpcSystem::cleanup);
+
+ rpcSystemClassLoaderCloseFuture.whenComplete(
Review comment:
forward requires both the source&target future to return the same type,
which isn't the case here (Void vs Result)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
