NicoK commented on a change in pull request #16352:
URL: https://github.com/apache/flink/pull/16352#discussion_r663712129
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobVertexFlameGraphHandler.java
##########
@@ -63,6 +66,7 @@ public JobVertexFlameGraphHandler(
executionGraphCache,
executor);
this.threadInfoOperatorTracker = threadInfoOperatorTracker;
+ this.isFlameGraphEnabled = isFlameGraphEnabled;
Review comment:
if `threadInfoOperatorTracker == null` when `isFlameGraphEnabled =
false`, then why do we need the extra boolean? Couldn't we just decide on
`threadInfoOperatorTracker == null`?
Also: could you mark `threadInfoOperatorTracker` (field and parameter) as
`@Nullable`?
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/job/JobVertexFlameGraphHandler.java
##########
@@ -63,6 +66,7 @@ public JobVertexFlameGraphHandler(
executionGraphCache,
executor);
this.threadInfoOperatorTracker = threadInfoOperatorTracker;
+ this.isFlameGraphEnabled = isFlameGraphEnabled;
Review comment:
That may indeed also be an argument.
I wasn't 100% sure what the best way would be...I'm going to give this PR a
go but will ask a colleague working on this stack to take a second look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
