zhangyy91 commented on a change in pull request #16367:
URL: https://github.com/apache/flink/pull/16367#discussion_r664206130
##########
File path:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/streaming/util/TestStreamEnvironment.java
##########
@@ -75,36 +81,28 @@ public static void setAsContext(
TestStreamEnvironment env =
new TestStreamEnvironment(
miniCluster, parallelism, jarFiles,
classpaths);
- randomize(conf);
+ if (RANDOMIZE_CHECKPOINTING_CONFIG) {
+ randomize(
+ conf,
ExecutionCheckpointingOptions.ENABLE_UNALIGNED, true, false);
+ randomize(
+ conf,
+
ExecutionCheckpointingOptions.ALIGNMENT_TIMEOUT,
+ Duration.ofSeconds(0),
+ Duration.ofMillis(100),
+ Duration.ofSeconds(2));
+ }
+ if
(STATE_CHANGE_LOG_CONFIG.equals(STATE_CHANGE_LOG_CONFIG_ON)) {
+ conf.set(CheckpointingOptions.ENABLE_STATE_CHANGE_LOG,
true);
+ } else if
(STATE_CHANGE_LOG_CONFIG.equals(STATE_CHANGE_LOG_CONFIG_RAND)) {
Review comment:
@rkhachatryan Thanks for the review! I have applied the comment in
another commit. Would you mind taking another look? Thanks.
##########
File path:
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/streaming/util/TestStreamEnvironment.java
##########
@@ -75,36 +81,28 @@ public static void setAsContext(
TestStreamEnvironment env =
new TestStreamEnvironment(
miniCluster, parallelism, jarFiles,
classpaths);
- randomize(conf);
+ if (RANDOMIZE_CHECKPOINTING_CONFIG) {
+ randomize(
+ conf,
ExecutionCheckpointingOptions.ENABLE_UNALIGNED, true, false);
+ randomize(
+ conf,
+
ExecutionCheckpointingOptions.ALIGNMENT_TIMEOUT,
+ Duration.ofSeconds(0),
+ Duration.ofMillis(100),
+ Duration.ofSeconds(2));
+ }
+ if
(STATE_CHANGE_LOG_CONFIG.equals(STATE_CHANGE_LOG_CONFIG_ON)) {
+ conf.set(CheckpointingOptions.ENABLE_STATE_CHANGE_LOG,
true);
+ } else if
(STATE_CHANGE_LOG_CONFIG.equals(STATE_CHANGE_LOG_CONFIG_RAND)) {
Review comment:
@rkhachatryan IMHO, this PR is to config the changelog state backend in
tests. It might be better to merge them separately and then enable the
randomization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
