twalthr commented on a change in pull request #16287:
URL: https://github.com/apache/flink/pull/16287#discussion_r664481148
##########
File path:
flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/api/TableEnvironmentTest.java
##########
@@ -78,6 +78,19 @@ public void testConnect() {
assertCatalogTable(CatalogTableImpl.fromProperties(table.toProperties()));
}
+ @Test
+ public void testTableFromDescriptor() {
+ final TableEnvironmentMock tEnv =
TableEnvironmentMock.getStreamingInstance();
+
+ final Schema schema = Schema.newBuilder().column("f0",
DataTypes.INT()).build();
+ final TableDescriptor descriptor =
+ TableDescriptor.forConnector("fake").schema(schema).build();
+
+ Table table = tEnv.from(descriptor);
+ assertEquals(
Review comment:
I thought we have access to the original `CatalogTable` in the stack.
But the identifier should be enough to look it up in the catalog manager and
verify that `connector=fake` has ended up in the right location.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
