beyond1920 opened a new pull request #16397:
URL: https://github.com/apache/flink/pull/16397
## What is the purpose of the change
The pr aims to refactor the time indicator materialization, including:
1. split Match_ROWTIME return type converter into a separator class which
works before `DEFAULT_REWRITE` which contains rules to convert windowProperties
2. Move `time_indicator` materialize after `logical_rewrite` phase, which is
closely before the physical optimization
3. Port `RelTimeIndicatorConverter` from SCALA to JAVA
4. Refactor `RelTimeIndicatorConverter` to match `FlinkLogicalRel`
## Brief change log
- Split Match_ROWTIME return type converter into a separator class named
`MatchRowTimeConverter`
- Introduce `FlinkMatchRowTimeConvertProgram` which call
`MatchRowTimeConverter`. It works just before `DEFAULT_REWRITE` which contains
rules to convert windowProperties
- Move `time_indicator` materialize after `logical_rewrite` phase, which
is closely before the physical optimization
- Port `RelTimeIndicatorConverter` from SCALA to JAVA
- Refactor `RelTimeIndicatorConverter` to match `FlinkLogicalRel`
- Update `LogicalWindowAggregateRuleBase#getOutAggregateGroupExpression`
because after moving `time_indicator` materialize after `logical_rewrite`
phase, `LogicalWindowAggregateRuleBase` should handle time indicator case
- Update updated xml for plan test which are expected because moving
`time_indicator` materialize after `logical_rewrite` phase, which is closely
before the physical optimization
## Verifying this change
Existed UT/IT
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
