[ https://issues.apache.org/jira/browse/FLINK-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15306684#comment-15306684 ]
Arnaud Linz commented on FLINK-3763: ------------------------------------ IMO, this source lacks many RMQ features in order to make it usable in production. VirtualHost is one of them ; but I think that the whole RabbitMQ factory should be made available to the user. Currently it is not even accessible from an inherited class. It would also be a good idea to make this source truly cancellable by adding something like {{consumer.getChannel().abort(AMQP.REPLY_SUCCESS, "Cancellation requested by user");}} in the {{cancel()}} method or else it may never end in a clean way. > RabbitMQ Source/Sink standardize connection parameters > ------------------------------------------------------ > > Key: FLINK-3763 > URL: https://issues.apache.org/jira/browse/FLINK-3763 > Project: Flink > Issue Type: Improvement > Components: Streaming Connectors > Affects Versions: 1.0.1 > Reporter: Robert Batts > Assignee: Subhankar Biswas > > The RabbitMQ source and sink should have the same capabilities in terms of > establishing a connection, currently the sink is lacking connection > parameters that are available on the source. Additionally, VirtualHost should > be an offered parameter for multi-tenant RabbitMQ clusters (if not specified > it goes to the vhost '/'). > Connection Parameters > =================== > - Host - Offered on both > - Port - Source only > - Virtual Host - Neither > - User - Source only > - Password - Source only > Additionally, it might be worth offer the URI as a valid constructor because > that would offer all 5 of the above parameters in a single String. -- This message was sent by Atlassian JIRA (v6.3.4#6332)