Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/2047#discussion_r65087502
--- Diff:
flink-streaming-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi/NiFiSource.java
---
@@ -143,4 +144,13 @@ public void close() throws Exception {
client.close();
}
+ /**
+ * {@inheritDoc}
+ * <p>
+ * Sets the {@link #isRunning} flag to {@code false}.
+ */
+ @Override
+ public void stop() {
+ this.isRunning = false;
--- End diff --
Stop should not call close(), actually. It should just cause the main
source loop to gracefully exit.
Close() will happen anyways after that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
