JingsongLi commented on a change in pull request #16163:
URL: https://github.com/apache/flink/pull/16163#discussion_r665081352
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/BridgingFunctionGenUtil.scala
##########
@@ -147,7 +147,8 @@ object BridgingFunctionGenUtil {
externalOperands,
returnType)
} else {
- generateScalarFunctionCall(ctx, functionTerm, externalOperands,
outputDataType)
+ generateScalarFunctionCall(ctx, functionTerm, externalOperands,
Review comment:
I think the right way to remove `copy` is in above
`prepareExternalOperands`.
- We should check `ExternalGeneratedExpression` in
`genToExternalConverterAll`.
- Then remove `case external: ExternalGeneratedExpression` in
`generateScalarFunctionCall`, we have already generated the `externalOperands`!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
