Airblader commented on a change in pull request #16290:
URL: https://github.com/apache/flink/pull/16290#discussion_r665123901
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Table.java
##########
@@ -1355,6 +1355,28 @@ default Table limit(int offset, int fetch) {
*/
TableResult executeInsert(String tablePath, boolean overwrite);
+ /**
+ * Declares that the pipeline defined by the given {@link Table} object
should be written to a
+ * table defined by a {@link TableDescriptor}. It executes the insert
operation.
Review comment:
I added docs for now that note the behavior of registering the sink
multiple times. I'm not sure I understand how a statement set solves this
issue, though, at least using `StatementSet#addInsert(TableDescriptor, Table)`
would have the same behavior, wouldn't it?
Ideally we'd probably avoid registering tables multiple times, and instead
ensure that the same descriptor is only effectively registered once. But that'd
require a solid/safe hash function that guarantees different values for
different descriptors – or for the descriptor itself to generate a UUID which
it exposes (yuck :-/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
