TsReaper commented on a change in pull request #16349:
URL: https://github.com/apache/flink/pull/16349#discussion_r665125810



##########
File path: 
flink-table/flink-table-code-splitter/src/main/resources/META-INF/NOTICE
##########
@@ -1,4 +1,4 @@
-flink-table-code-splitter
+Flink : Table : Code Splitter

Review comment:
       I've checked other NOTICE files. All other NOTICE files use artifact id 
instead of module name. So currently I'll follow these behavior.
   
   However for the "integrated" NOTICE file generated in modules like 
`flink-table-uber`, modules without hand-written NOTICE files are referenced 
with their module name. I think there might be some conflicts here. @zentol 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to