AHeise commented on a change in pull request #16401:
URL: https://github.com/apache/flink/pull/16401#discussion_r665123285



##########
File path: 
flink-connectors/flink-connector-jdbc/src/test/resources/log4j2-test.properties
##########
@@ -21,6 +21,14 @@
 rootLogger.level = OFF
 rootLogger.appenderRef.test.ref = TestLogger
 
+# debugging FLINK-22889
+logger.xa.name = org.apache.flink.connector.jdbc.xa.JdbcExactlyOnceSinkE2eTest
+logger.xa.level = DEBUG
+logger.task.name = org.apache.flink.runtime.taskmanager.Task
+logger.task.level = WARN
+logger.jdbc.name = org.apache.flink.connector.jdbc
+logger.jdbc.level = ERROR

Review comment:
       This would be reduced to the default INFO on AZP. Is this intended?

##########
File path: 
flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/xa/JdbcExactlyOnceSinkE2eTest.java
##########
@@ -87,6 +89,8 @@
 @RunWith(Parameterized.class)
 public class JdbcExactlyOnceSinkE2eTest extends JdbcTestBase {
     private static final Random RANDOM = new 
Random(System.currentTimeMillis());
+    // debugging FLINK-22889

Review comment:
       Tbh except for some statements, I'd leave the logger in.

##########
File path: 
flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/xa/JdbcExactlyOnceSinkE2eTest.java
##########
@@ -343,10 +360,15 @@ public void snapshotState(FunctionSnapshotContext 
context) {
         }
 
         private void sleep(Supplier<Boolean> condition) {
+            long start = System.currentTimeMillis();
             while (condition.get()
                     && running
                     && !Thread.currentThread().isInterrupted()
                     && haveActiveSources()) {
+                if (System.currentTimeMillis() - start > 10_000) {
+                    LOG.debug("Slept more than 10s", new Exception());

Review comment:
       Is this enough to understand why it hangs? I guess through the 
stacktrace we know for which condition it hangs...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to