gaoyunhaii commented on a change in pull request #14857:
URL: https://github.com/apache/flink/pull/14857#discussion_r665369625
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
##########
@@ -1864,6 +1866,61 @@ static void processMailTillCheckpointSucceeds(
testHarness.getTaskStateManager().getWaitForReportLatch().await();
}
+ @Test
+ public void testWaitingForPendingCheckpointsOnFinished() throws Exception {
Review comment:
Sorry for not check if the test is work in reverse cases... It seems
indeed not easy to accurately test "wait", and I think the suggested
implementation is very good. I have changed the test to this implementation~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
