NicoK commented on a change in pull request #16419:
URL: https://github.com/apache/flink/pull/16419#discussion_r665960650
##########
File path:
flink-runtime-web/web-dashboard/src/app/pages/job/overview/flamegraph/job-overview-drawer-flamegraph.component.html
##########
@@ -41,6 +41,6 @@
<nz-spin *ngIf="isLoading"></nz-spin>
</div>
-
-
-
+<ng-template #notAvailable>
+ <span>Flame graph is currently unavailable</span>
Review comment:
In that case, since (afaik) we can't distinguish between the Flamegraphs
being disabled vs. us just waiting for the first results to appear, we'd have
to provide a generic text like
> Flame graph currently unavailable
> We are either waiting for the first samples to create a flame graph or
this feature is currently disabled (enable it by setting
[`rest.flamegraph.enabled:
true`](https://ci.apache.org/projects/flink/flink-docs-release-1.13/docs/deployment/config/#rest-flamegraph-enabled))
If we can actually distinguish the two, then splitting these scenarios up
into two different messages would be even better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
